-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Move the edit template blocks notification to editor package #56901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
getdave,
ramonjd,
aaronrobertshaw and
a team
December 8, 2023 13:29
Size Change: -23 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Flaky tests detected in 5b874bf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7143754495
|
youknowriad
force-pushed
the
move/edit-template-notification
branch
from
December 8, 2023 16:24
1bd7b7e
to
5b874bf
Compare
ellatrix
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
In the site editor, when you click the template blocks, you get a notification to edit the template when in "template locked" mode. This PR moves this notification to the editor package which basically brings it to the post editor as well.
Testing Instructions
1- Open a page in the post editor
2- Enable template preview
3- Click any template block to see the notification